Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tubes have gone crazy #36

Closed
ancientmarinerdev opened this issue Sep 1, 2024 · 36 comments
Closed

Tubes have gone crazy #36

ancientmarinerdev opened this issue Sep 1, 2024 · 36 comments

Comments

@ancientmarinerdev
Copy link

Ok, so this is weird. This setup, the corner turned from this to red, so I replaced it with a tube and it went back to how I wanted it.

Screenshot_20240901_222356

Fine so far, right, however, now, when the crusher completes, it sometimes puts the ores in the pebbles slot, and then the pebbles just bounce around the tubes aimlessly until they clip outside the tubes and just head away as can be seen in the picture.

So there is a crusher bug, with other weirdness in there also.

@ancientmarinerdev
Copy link
Author

More weirdness:

Screenshot_20240901_223518
Screenshot_20240901_223502

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

Ok, so this is weird. This setup, the corner turned from this to red, so I replaced it with a tube and it went back to how I wanted it.

Screenshot_20240901_222356

Fine so far, right, however, now, when the crusher completes, it sometimes puts the ores in the pebbles slot, and then the pebbles just bounce around the tubes aimlessly until they clip outside the tubes and just head away as can be seen in the picture.

So there is a crusher bug, with other weirdness in there also.

tubes turn into broken tubes when there are more than 30 stacks in 1 tube... that is intentional, handle your overflow with a trashcan (trashcan has basically the lowest priority)

@TheEt1234
Copy link
Contributor

More weirdness:

Screenshot_20240901_223518 Screenshot_20240901_223502

?

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

Edit: thats probably not what was happening, im sorry

image
ok its explained in the quests, nothing to fix (besides the "more weirdness"

@ancientmarinerdev
Copy link
Author

image ok its explained in the quests, nothing to fix (besides the "more weirdness"

The crusher bug is causing it. Basically, I'm trying to feed the pebble slot, buy an iron element is going in there. It should not accept a mineral in pebble slot. It only backs up because of that.

Secondly other tubes are spitting items outside the pipes which is not expected. So there is 2 bugs there.

@TheEt1234
Copy link
Contributor

Fine so far, right, however, now, when the crusher completes, it sometimes puts the ores in the pebbles slot,

OH i didnt notice that im so sorry

@TheEt1234
Copy link
Contributor

could you tell me more about the crusher bug (how to reproduce it)

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

Secondly other tubes are spitting items outside the pipes which is not expected. So there is 2 bugs there.

And how do i reproduce this? i've tried to just put up tubes and spam items into them but what you've described never happens

The "Clipping around endlessly" may be caused by (network) lag, ive let a lot of stacks run around in tubes and that never happened

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

wait this just happened to me now... with an unknown item.... weird

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

but only and 100% of the time with unknown items... everything else works normally

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

and crusher doesn't have any code to put anything in the input slot, so it's not a crusher bug, it's most likely a tube bug

@ancientmarinerdev
Copy link
Author

Screenshot_20240902_174215
Screenshot_20240902_174142

I think it's due to a full output for the auto-injector. I think it tries to pass the item on, fails and sends it back.

I'm also getting weird stuff where on my:

puncher -> auto-injector -> storinator

When the storinator is full, it keeps producing, and pushing to the auto-injector. As I remove say 10 stacks from the chest, it keeps putting more in the storinator so it's full within seconds. I think items go into limbo in the auto-injector and build up there. If they cannot go to output, I'm guessing they go back to where they came out of.

@ancientmarinerdev
Copy link
Author

I don't think the auto-injector should try and pull if there is no space to push stuff.

@ancientmarinerdev
Copy link
Author

If you see the first screenshot in this though:

#36 (comment)

They're filter injectors from matter extractors, and there is space in the chest, yet the matter has clipped out of the tube which it never used to do.

@TheEt1234
Copy link
Contributor

If they cannot go to output, I'm guessing they go back to where they came out of.

Oh thats weird..... let me check if regular pipeworks has this problem

@ancientmarinerdev
Copy link
Author

Screenshot_20240902_175149
If you see this image, the storinator at the top should only receive matter blobs (made from first auto-crafter), (the second makes pebbles), yet somehow, minerals crushed from pebbles ended up in that chest. There is a weird backflow thing going on which should not happen.

@TheEt1234
Copy link
Contributor

i see now

@TheEt1234
Copy link
Contributor

pipeworks has this same problem too, and i will give you a consistant setup to reproduce it shortly

@TheEt1234
Copy link
Contributor

image
im back, Chest A has some items it wants to push
Chest B is full
when it tries to push, the stuff first tries to go to chest b, then after some delay, ends up back in chest A

@TheEt1234
Copy link
Contributor

the reason this is super problematic for crushers is because the output inventory is different than the input inventory

so it transfers stuff from the input to the output

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

with that knowledge, the obvious solution for this (handle your overflows, in sbz the trashcan is the item void)
image

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

Or just put up an infinite storinator and hope you will never get 5 000 stacks of random chemicals (btw you can push to those unknown slots but not pull from them, also you can do both)

@TheEt1234
Copy link
Contributor

so, the solution to the crusher bug: manage your overflow correctly

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 2, 2024

I don't think the auto-injector should try and pull if there is no space to push stuff.

But this is a good idea so i will attempt it

@TheEt1234
Copy link
Contributor

ok so due to how pipeworks works thats slightly tricky

@TheEt1234
Copy link
Contributor

so instead, i will just make the crusher only accept pebbles

@TheEt1234
Copy link
Contributor

If you see the first screenshot in this though:

#36 (comment)

They're filter injectors from matter extractors, and there is space in the chest, yet the matter has clipped out of the tube which it never used to do.

oh i now saw the matter. yeah that's super weird, i don't understand much of pipeworks's entity code

does it end up in that chest?

does it happen consistently?

and also, note: tube routing like this isnt very efficent *at large scales* as the items just wander around the tubes, consider putting up some high priority tubes near the storinator and low priority tubes from locations that are away from the storinator if you expand this

what happens if you break+place the tube?

@ancientmarinerdev
Copy link
Author

My feeling is it was to do with puncher, and the fact it stocked up stuff that got stick in the injector. I'm guessing the extra item entities may have had an effect on performance. Not sure for certain though. I've cleared it out and it seems ok for now, but I'll see have to keep an eye on it.

That crusher input change will definitely help. If it ends up crushing more stuff, I guess it can change to a group. :)

@ancientmarinerdev
Copy link
Author

If I have automation set up and I put empty water vials in, they just get spat out quickly. I'm wondering if maybe we need an extra input slot for empty liquid containers.

@TheEt1234
Copy link
Contributor

TheEt1234 commented Sep 3, 2024

My feeling is it was to do with puncher, and the fact it stocked up stuff that got stick in the injector. I'm guessing the extra item entities may have had an effect on performance. Not sure for certain though. I've cleared it out and it seems ok for now, but I'll see have to keep an eye on it.

That crusher input change will definitely help. If it ends up crushing more stuff, I guess it can change to a group. :)

see mt-mods/pipeworks#135 maybe?

(and also, to keep it absolutely clear, punchers don't need injectors, neither do node breakers)

@TheEt1234
Copy link
Contributor

also the real way to fix the crusher issue is to handle your overflows

@ChefZander
Copy link
Owner

Is this resolved?

@TheEt1234
Copy link
Contributor

Is this resolved?

no, but its very low priority

@ChefZander
Copy link
Owner

Is this resolved?

no, but its very low priority

What's the issue?

@TheEt1234
Copy link
Contributor

Is this resolved?

no, but its very low priority

What's the issue?

ive only reproduced this one: mt-mods/pipeworks#135

@TheEt1234
Copy link
Contributor

I can't do anything about this, only "upstream" pipeworks can, i don't know pipeworks code nearly as well as them, issue should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants