Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for custom network and subnetwork in circleci-server-windows-image-builder script #25

Open
nanophate opened this issue Jul 3, 2024 · 0 comments

Comments

@nanophate
Copy link
Contributor

Description

Currently in the circleci-server-windows-image-builder, the default network and subnetwork are hard-coded and cannot be customized directly.

Users have reported the need to use a specific network and subnetwork, other than the default ones when configuring the circleci-server-windows-image-builder script.

script:
  project_id: '{{ user "project_id" }}'
  account_file: '{{ user "account_file" }}'
  zone: '{{ user "gce_zone" }}'
  subnetwork: default
  tags:
    - packer-winrm

https://github.com/CircleCI-Public/circleci-server-windows-image-builder/blob/feb9f7dc307fabb9317148e5138ee0fffcf53b25/windows/visual-studio/packer.yaml#L73C5-L73C15

Problem arises when users need to specify a custom subnetwork, as the current script does not support this feature.

Users can currently get around this issue by forking the script and changing the subnetwork value. However, having this feature directly in the script would enhance convenience and productivity.

Desired Outcome:

Support for custom network and subnetwork specification in circleci-server-windows-image-builder by making the subnetwork field dynamic in the script.

AC:

  • Add option to specify custom network and subnetwork in the window/visual-studio/packer.yaml file
  • Update the project documentation to reflect this change

related links:

circleci-server-windows-image-builder script on GitHub here
Hashicorp Packer Google Compute Builder documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant