Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc-serialize v0.3.24 contains code that will be rejected by a future version of Rust #27

Open
almereyda opened this issue Mar 28, 2023 · 0 comments

Comments

@almereyda
Copy link
Contributor

Running the linter (which implies a build), a build or the tests outputs:

warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 6`

As seen in

We will be affected by this, as we are building from the rolling Rust upstream:

FROM rust:latest AS build

Implying that

https://github.com/CirclesUBI/pathfinder2/blob/4846da28161055617d790e3ce09613b5c4a528aa/.github/workflows/test.yml#LL29C28-L29C48

also installs Rust in case of the test workflow.

Apparently this manual step could now also be replaced with the upstream supported https://github.com/foundry-rs/foundry-toolchain action. (found via https://github.com/foundry-rs/foundry/#installing-for-ci-in-github-action)

For Dockerfile-based environments, they suggest to build on their upstream image, as per https://github.com/foundry-rs/foundry/#installing-via-docker and https://book.getfoundry.sh/tutorials/foundry-docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant