[Gameplay] Unit death

[ColdenCullen]

No description provided.

[liam-middlebrook]

Fixed in 53915fd

[PxlBuzzard]

Crash on death:

core.exception.AssertError@C:\D\dmd2\windows\bin\..\..\src\phobos\std\range.d(4120): range is smaller than amount of items to pop
----------------
0x0059A495 in _d_assert_msg
0x00457B2A in pure @safe dash.core.gameobject.GameObject[] std.algorithm.remove!(2, dash.core.gameobject.GameObject[], int).remove(dash.core.gameobject.GameObject[], int) at C:\D\dmd2\windows\bin\..\..\src\phobos\std\algorithm.d(8659)
0x0044D937 in void dash.core.gameobject.GameObject.removeChild(dash.core.gameobject.GameObject) at C:\Users\User\Documents\RobotGhosts\..\..\AppData\Roaming\dub\packages\dash-0.10.0\source\dash\core\gameobject.d(422)
0x00454746 in void dash.core.scene.Scene.removeChild(dash.core.gameobject.GameObject) at C:\Users\User\Documents\RobotGhosts\..\..\AppData\Roaming\dub\packages\dash-0.10.0\source\dash\core\scene.d(145)
0x0044BBED in void unit.Unit.update() at C:\Users\User\Documents\RobotGhosts\Scripts\unit.d(300)
0x0044CEDC in D4dash4core10gameobject10GameObject6updateMFZ14__foreachbody1MFKC8TypeInfoKC4dash10components9component9ComponentZi at C:\Users\User\Documents\RobotGhosts\..\..\AppData\Roaming\dub\packages\dash-0.10.0\source\dash\core\gameobject.d(233)

[PxlBuzzard]

We changed the default game type to units respawning rather than dying, so we don't get this issue during the regular gameplay experience anymore. However, I am leaving the issue open since we never solved the splicing bug, currently in unit.d#384.