Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL-4191] Install Node.js using apt-get install in Dockerfile's #6241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CL-4191] Install Node.js using apt-get install in Dockerfile's #6241

wants to merge 2 commits into from
+31 −18

Conversation

adessy
Copy link
Contributor

@adessy adessy commented Oct 25, 2023 •
edited
Loading

According to Node.js documentation:

The installation scripts setup_XX.x are no longer supported and are not needed anymore, as the installation process is straightforward for any RPM and DEB distro.

Those scripts will be eventually made inactive. Furthermore, to encourage people to stop using them, the scripts wait (suspend the execution) for 60 seconds before resuming the installation.

Changelog

Technical

  • Install Node.js (for mjml) in back-end Dockerfiles using apt-get instead of the previous installation script that's now deprecated.

@adessy
[CL-4191] Install Node.js using apt-get install in Dockerfile's
e6dbe80 
According to Node.js documentation:
> The installation scripts setup_XX.x are no longer supported and are not needed anymore, as the installation process is straightforward for any RPM and DEB distro.

 Those scripts will be eventually made inactive. Furthermore, to encourage people to stop using them, the scripts wait (suspend the execution) for 60 seconds before resuming the installation.
@adessy adessy requested a review from alexander-cit October 25, 2023 08:51
alexander-cit
alexander-cit approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@alexander-cit alexander-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you tested emails manually and they work fine. If so, good to merge.

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Nov 1, 2023 •
edited
Loading

Messages
📖 Changelog provided 🎉
📖 Jira issue: CL-4191
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 7bcc73e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-cit alexander-cit alexander-cit approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adessy @cl-dev-bot @alexander-cit