Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-TICKET] Delete location input from component library #6243

Merged
merged 3 commits into from
Oct 25, 2023
Merged

[NO-TICKET] Delete location input from component library #6243

merged 3 commits into from
Oct 25, 2023

Conversation

IvaKop
Copy link
Contributor

@IvaKop IvaKop commented Oct 25, 2023

Since we moved the google maps API calls to the back-end, the location input is no longer used or needed.

Changelog

@IvaKop IvaKop requested a review from luucvanderzee October 25, 2023 10:34
@IvaKop IvaKop changed the title [NO-TICKET} Delete location input from component library [NO-TICKET] Delete location input from component library Oct 25, 2023
@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Oct 25, 2023 •
edited
Loading

Warnings
⚠️

The changelog is empty. What should I put in the changelog?
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 15bb4a6

luucvanderzee
luucvanderzee approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@luucvanderzee luucvanderzee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@IvaKop IvaKop merged commit 7b23763 into master Oct 25, 2023
1 check passed
@IvaKop IvaKop deleted the delete-location-input branch November 6, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luucvanderzee luucvanderzee luucvanderzee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvaKop @cl-dev-bot @luucvanderzee