Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAN-479] Scroll to error message in JSON forms #6278

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

amanda-anderson
Copy link
Contributor

@amanda-anderson amanda-anderson commented Oct 31, 2023

Description

We weren't scrolling up to error messages in JSON forms, and this was super confusing for users. Now on form submit we scroll up if validation fails or API errors are returned + displayed.

Changelog

Fixed

  • User is now scrolled properly to error messages in idea, survey, and registration forms

@notion-workspace
Copy link

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Oct 31, 2023

Warnings
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖 Changelog provided 🎉
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against a40e621

@amanda-anderson amanda-anderson changed the title [TAN-479] Scroll to error message is JSON forms [TAN-479] Scroll to error message in JSON forms Oct 31, 2023
@IvaKop IvaKop self-requested a review October 31, 2023 14:26
@amanda-anderson amanda-anderson merged commit febc2db into master Nov 2, 2023
18 checks passed
@amanda-anderson amanda-anderson deleted the TAN-479-fix-error-message-scroll branch November 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants