Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table and model update logic #971

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kroenlein
Copy link
Collaborator

Citrine Python PR

Description

This PR adds a private method to table_config to migrate a TableConfig to a multistep materials table, and a private method to graph_predictor to migrate a GraphPredictor to one that includes AttributeAccumulationPredictors.

https://citrine.atlassian.net/browse/PNE-731

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant