Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme settings #56

Open
terotik opened this issue Jan 4, 2020 · 0 comments
Open

Theme settings #56

terotik opened this issue Jan 4, 2020 · 0 comments

Comments

@terotik
Copy link
Contributor

terotik commented Jan 4, 2020

Consider adding theme settings object. Currently theme is set by passing THEME_IDENTIFIER environment variable for the app.

App then loads appropriate styles and assets from directory named as THEME_IDENTIFIER. As we don't have a way of checking availability of individual asset files this technique expects every theme to have every required file available. Theme settings object would give themes more freedom to define sources for individual assets, and let them use default options for selected assets.
@terotik terotik mentioned this issue Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terotik