Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-1939 Fix problem where validation errors would remain when filling sub-contacts in cable report application #382

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

markohaarni
Copy link
Contributor

Description

If there were validation errors when user pressed Fill with own information button, those errors remained even when they should not.

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-1939

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

  1. Edit for example customer contacts name field and leave it empty
  2. Click some other field. There should be validation error: "Kenttä on pakollinen".
  3. Click "Täytä omilla tiedoilla" button.
  4. Validation error(s) should go away from that customer contact.

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

Other relevant info

Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

…g sub-contacts in cable report application

If there were validation errors when user pressed Fill with own information button,
those errors remained even when they should not.
@markohaarni markohaarni merged commit 2c26416 into dev Oct 9, 2023
1 check passed
@markohaarni markohaarni deleted the HAI-1939 branch October 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants