Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hl 1498 talpa errors #3620

Merged
merged 7 commits into from
Dec 4, 2024
Merged

feat: Hl 1498 talpa errors #3620

merged 7 commits into from
Dec 4, 2024

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Dec 2, 2024 •
edited
Loading

Description ✨

Actually fix for HL-1564(https://helsinkisolutionoffice.atlassian.net/browse/HL-1564?atlOrigin=eyJpIjoiNTViYjY0YTcyYmFiNGYzMzhlOTMzOTNmYzNjYTEzYjYiLCJwIjoiaiJ9)

  • Instalments are now updated as accepted only after decision details are received from Ahjo REST api
  • Initial instalment status is now WAITING
  • move decision details response handling away from the cli command and into its own handler, for more testable code, also write test for the handling of the decision detail response and improve error handling

Issues 🐛

Testing ⚗️

Screenshots 📸

Additional notes 🗒️

@rikuke rikuke marked this pull request as ready for review December 2, 2024 08:22
@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3620.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3620.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3620.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3620.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3620.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke force-pushed the HL-1498-talpa-errors branch from 8418992 to bda56f7 Compare December 4, 2024 09:57
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
59 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JanneJuhola
JanneJuhola approved these changes Dec 4, 2024
View reviewed changes
backend/benefit/applications/enums.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuossa taitaa olla copy-pastea.
Decision maker- virhe annetaan vaikka virhe on tittelissä tai pykälässä.

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3620.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3620.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3620.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3620.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3620.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke merged commit 47307a6 into main Dec 4, 2024
64 checks passed
@rikuke rikuke deleted the HL-1498-talpa-errors branch December 4, 2024 10:41
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanneJuhola JanneJuhola JanneJuhola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikuke @terovirtanen @JanneJuhola