Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Optional fields should be nullable #315

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ezkat
Copy link
Collaborator

@ezkat ezkat commented Jan 9, 2024

Hotfix: Optional fields should be nullable

Fixes oversight with optional fields

Trello card


Breakdown:

Respa API

  1. resources/api/base.py

    • Fix field handling
  2. resources/api/resource.py

    • Set optional fields to allow null
  3. resources/tests/test_resource_api.py

    • Create test

@ezkat ezkat requested a review from SanttuA January 9, 2024 07:36
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f7dba8) 76.98% compared to head (c8df502) 76.99%.
Report is 1 commits behind head on production.

Additional details and impacted files
@@             Coverage Diff             @@
##           production     #315   +/-   ##
===========================================
  Coverage       76.98%   76.99%           
===========================================
  Files             500      500           
  Lines           26854    26865   +11     
  Branches         2732     2733    +1     
===========================================
+ Hits            20673    20684   +11     
  Misses           5648     5648           
  Partials          533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ezkat ezkat merged commit 054d40b into production Jan 9, 2024
4 checks passed
@ezkat ezkat deleted the hotfix/respa-api-optional-fields branch February 23, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants