Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multisign Support #1695

Open
belane opened this issue Nov 13, 2018 · 10 comments
Open

Feature: Multisign Support #1695

belane opened this issue Nov 13, 2018 · 10 comments
Assignees
Labels
enhancement High An issue above regular priority

Comments

@belane
Copy link
Member

belane commented Nov 13, 2018

Please add Multisign support for transfers and invocations. I think in the blockchain era it is a must.

It can cover both cases, when the user has all the keys or when multiple users are involved.
Allowing an user to create a signed transaction, export it and sent to another user who will import, sign and relay.

@ranbena
Copy link
Contributor

ranbena commented Nov 20, 2018

Please assign this to me if possible

@comountainclimber
Copy link
Member

@ranbena this task is officially assigned to you however it is not possible for me to assign contributors who do not have write access to the repo... Keep contributing and this wont be an issue 😄 for now assume it is assigned 👍

@ranbena ranbena self-assigned this Dec 23, 2018
@comountainclimber comountainclimber added the High An issue above regular priority label Jan 25, 2019
@vncoelho
Copy link

We have some example of javascript code for that at https://github.com/NeoResearch/neocompiler-eco/tree/master/public/js/eco-scripts, I can select each part for you @ranbena. We also used that template for the neonjs.

@uvmetal
Copy link

uvmetal commented Apr 11, 2019

Is there any movement on this? I was planning to add multisign to neotools as a test and I could carry it over to this eventually.

This feature should be high priority to keep the wallet competitive with others in the space.

@vncoelho
Copy link

I believe it is on the way, @phetter.
We have some javascript codes for this support, @comountainclimber:
https://github.com/NeoResearch/neocompiler-eco/blob/master/public/js/eco-scripts/rawMultiSigConversions.js

https://github.com/NeoResearch/neocompiler-eco/blob/af79b9ff09f711a2476e9090d7dabcdc80e9d701/public/js/eco-scripts/transfers_NeonJS.js#L83-L178

Neon-js also added some support.

We are also doing a PR now on https://neocompiler.io for allowing multisig to invoke contracts:
NeoResearch/neocompiler-eco#55

Let's share these codes and make it happen! 💃

@uvmetal
Copy link

uvmetal commented Apr 11, 2019

The code you provided here is great (https://github.com/NeoResearch/neocompiler-eco/blob/master/public/js/eco-scripts/rawMultiSigConversions.js). I will review further with plans to implement to neotools and neolink (these will be slow to happen as C.R.E.A.M.) :)

I like standard modules. <3

Thanks so much.

@ranbena ranbena removed their assignment Apr 12, 2019
@ranbena
Copy link
Contributor

ranbena commented Apr 12, 2019

Sry comrades. I am not on this assignment any more.

@vncoelho
Copy link

@comountainclimber

Time to go bouldering for a week and less snowboarding...kkkk ahauahah

check dylan https://cdn.discordapp.com/attachments/479084114629361675/565892228288086016/image0.jpg

@comountainclimber comountainclimber self-assigned this May 21, 2019
@comountainclimber
Copy link
Member

comountainclimber commented May 28, 2019

We are well on our way to supporting multi sig transaction signing as I am currently almost done with being able to import a transaction object for offline signing... It should be mostly trivial to support signing for multi sig transactions via this flow.

Support for generating a multi sig account will come shortly after 😃

@comountainclimber
Copy link
Member

#1867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement High An issue above regular priority
Projects
None yet
Development

No branches or pull requests

6 participants