-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Multisign Support #1695
Comments
Please assign this to me if possible |
@ranbena this task is officially assigned to you however it is not possible for me to assign contributors who do not have write access to the repo... Keep contributing and this wont be an issue 😄 for now assume it is assigned 👍 |
We have some example of javascript code for that at https://github.com/NeoResearch/neocompiler-eco/tree/master/public/js/eco-scripts, I can select each part for you @ranbena. We also used that template for the neonjs. |
Is there any movement on this? I was planning to add multisign to neotools as a test and I could carry it over to this eventually. This feature should be high priority to keep the wallet competitive with others in the space. |
I believe it is on the way, @phetter. Neon-js also added some support. We are also doing a PR now on https://neocompiler.io for allowing multisig to invoke contracts: Let's share these codes and make it happen! 💃 |
The code you provided here is great (https://github.com/NeoResearch/neocompiler-eco/blob/master/public/js/eco-scripts/rawMultiSigConversions.js). I will review further with plans to implement to neotools and neolink (these will be slow to happen as C.R.E.A.M.) :) I like standard modules. <3 Thanks so much. |
Sry comrades. I am not on this assignment any more. |
Time to go bouldering for a week and less snowboarding...kkkk ahauahah check dylan https://cdn.discordapp.com/attachments/479084114629361675/565892228288086016/image0.jpg |
We are well on our way to supporting multi sig transaction signing as I am currently almost done with being able to import a transaction object for offline signing... It should be mostly trivial to support signing for multi sig transactions via this flow. Support for generating a multi sig account will come shortly after 😃 |
Please add Multisign support for transfers and invocations. I think in the blockchain era it is a must.
It can cover both cases, when the user has all the keys or when multiple users are involved.
Allowing an user to create a signed transaction, export it and sent to another user who will import, sign and relay.
The text was updated successfully, but these errors were encountered: