Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Circle-CI electron-builder image consolidation #2236

Open
ixje opened this issue Sep 7, 2021 · 0 comments
Open

Explore Circle-CI electron-builder image consolidation #2236

ixje opened this issue Sep 7, 2021 · 0 comments

Comments

@ixje
Copy link
Member

ixje commented Sep 7, 2021

There currently are 2 docker images used. 1 for Linux and 1 for Windows.

container_config: &container_config
docker:
- image: electronuserland/builder:wine-chrome-05.21
environment:
TARGET_ARCH: x64
working_directory: ~/neon-wallet
win_config: &win_config
docker:
- image: electronuserland/builder:wine
environment:
TARGET_ARCH: x64
working_directory: ~/neon-wallet

The Windows image has no tagged version other than latest which could become a problem at some point (i.e. neon-wallet currently doesn't work with node 16.x and that image might upgrade node from 14.17.0 to 16.x). It is unclear why this setup exists. The task is to explorer the differences between the 2 images and see if both platforms can use the same image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant