Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing Clojure frontend implementation #34

Open
13 of 17 tasks
tcsullivan opened this issue May 12, 2023 · 1 comment · Fixed by #42
Open
13 of 17 tasks

Finishing Clojure frontend implementation #34

tcsullivan opened this issue May 12, 2023 · 1 comment · Fixed by #42
Assignees

Comments

@tcsullivan
Copy link
Collaborator

tcsullivan commented May 12, 2023

Here is a list of what I believe is remaining for the initial frontend. I'm working on this in the frontend-styling branch; if anyone else wants to contribute to the code, just push your changes to that branch and we'll keep this list updated.

We can also use this issue to discuss any of these items.

  • Decide if we should use the logo in the Figma mockup

  • Confirm choice and order of filtering options

  • Move search bar to top of page

  • Search bar above results, or keep it on the sidebar?

  • Rename "Reload" and "Reset" buttons to something more user-friendly?

  • Back/Forward: Move these buttons to bottom of results list

  • Confirm if we want to show all results at once. Dropdown to choose results per page count?

  • Have a results count at the top of the page?

  • Fix posted and closed date formats (removed HH:MM:SS since they were all the same)

  • Confirm layout of result item info

  • Make entire result clickable for details rather than "View details" button

  • Indication that entire result is clickable (emphasis, color)?

  • Finish details page implementation

  • Make sure site is mobile-friendly

  • Consider using fonts (e.g. Roboto)

  • Styling/color for the filter controls

  • Write build/setup instructions

@tcsullivan tcsullivan self-assigned this May 12, 2023
@tcsullivan tcsullivan linked a pull request May 22, 2023 that will close this issue
@tcsullivan tcsullivan changed the title Finishing frontend implementation Finishing Clojure frontend implementation May 30, 2023
@tcsullivan
Copy link
Collaborator Author

#42 shouldn't have closed this just yet -- I'd like to keep this issue open until the frontend reaches "production" quality.

There are a couple mobile styling issues that need fixing:

  • We've seen some font size inconsistencies on the details page
  • iOS doesn't seem to like the woff2 format Google Fonts is providing

@tcsullivan tcsullivan reopened this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant