From 9fd419864d5cde6cd9e7b43544646ecc76535f58 Mon Sep 17 00:00:00 2001 From: Dor Harpaz Date: Thu, 5 Dec 2024 12:24:24 +0200 Subject: [PATCH] remove unneeded env-vars from the inline script in the CI --- .github/workflows/test-CI-dev.yml | 6 ------ .github/workflows/test-CI-main.yml | 6 ------ 2 files changed, 12 deletions(-) diff --git a/.github/workflows/test-CI-dev.yml b/.github/workflows/test-CI-dev.yml index 162921c3..2a213d90 100644 --- a/.github/workflows/test-CI-dev.yml +++ b/.github/workflows/test-CI-dev.yml @@ -43,7 +43,6 @@ jobs: if [[ "${{ github.event_name }}" == "pull_request_target" ]]; then echo "Handling pull_request_target event" echo "SHOULD_TEST_ALL_FILES=false" >> $GITHUB_ENV - target_branch="${{ github.event.pull_request.base.ref }}" if [ "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]; then echo "PR from a fork detected. Checking out the fork's branch." @@ -58,21 +57,16 @@ jobs: elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then echo "Handling workflow_dispatch event: No checkout needed" - target_branch="${{ github.ref_name }}" echo "SHOULD_TEST_ALL_FILES=true" >> $GITHUB_ENV - echo "list_of_ipynb_changed=**/*.ipynb" >> $GITHUB_ENV elif [[ "${{ github.event_name }}" == "push" ]]; then echo "Handling push event: No checkout needed" - target_branch="${{ github.ref_name }}" else echo "Unsupported event type: ${github.event_name}. Exiting." exit 1 fi - echo "target_branch=$target_branch" >> $GITHUB_OUTPUT - # Debugging: final git status echo "==== Git status after checkout ====" git status diff --git a/.github/workflows/test-CI-main.yml b/.github/workflows/test-CI-main.yml index 9b8a98e4..804761ca 100644 --- a/.github/workflows/test-CI-main.yml +++ b/.github/workflows/test-CI-main.yml @@ -46,7 +46,6 @@ jobs: if [[ "${{ github.event_name }}" == "pull_request_target" ]]; then echo "Handling pull_request_target event" echo "SHOULD_TEST_ALL_FILES=false" >> $GITHUB_ENV - target_branch="${{ github.event.pull_request.base.ref }}" if [ "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]; then echo "PR from a fork detected. Checking out the fork's branch." @@ -61,21 +60,16 @@ jobs: elif [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then echo "Handling workflow_dispatch event: No checkout needed" - target_branch="${{ github.ref_name }}" echo "SHOULD_TEST_ALL_FILES=true" >> $GITHUB_ENV - echo "list_of_ipynb_changed=**/*.ipynb" >> $GITHUB_ENV elif [[ "${{ github.event_name }}" == "push" ]]; then echo "Handling push event: No checkout needed" - target_branch="${{ github.ref_name }}" else echo "Unsupported event type: ${github.event_name}. Exiting." exit 1 fi - echo "target_branch=$target_branch" >> $GITHUB_OUTPUT - # Debugging: final git status echo "==== Git status after checkout ====" git status