-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biharmonic viscosity on Cubed-Sphere grid #3849
Labels
Comments
Oceananigans.jl/src/TurbulenceClosures/abstract_scalar_biharmonic_diffusivity_closure.jl Lines 86 to 95 in 3f62872
|
Oceananigans.jl/src/Operators/laplacian_operators.jl Lines 10 to 18 in 3f62872
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that there are 2 potential issues with implementation of biharmonic viscosity when used on cubed-sphere grid:
abstract_scalar_biharmonic_diffusivity_closure.jl
, we compute "ζ★ᶠᶠᶜ" (starting at line 86) directly without the special cases for the cubed-sphere corners (as we do for the vorticity), so I think this will not be right at the cube corners. An easy fix could be to use the vorticity function instead.Operators/laplacian_operators.jl
is more like a flux-form expression that does not work at the cubed-sphere corners. A way to fix this would be to use more like a vector-invariant analog where the laplacian is evaluated from the vorticity and divergence of the horizontal velocity component.The text was updated successfully, but these errors were encountered: