Fix positivity preserving WENO #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Nov 22, 2024
Co-authored-by: Gregory L. Wagner <[email protected]>
glwagner
approved these changes
Nov 22, 2024
|
@masonrogers14 try to run your case with this branch and see what happens! |
|
Thanks for flagging me--so far on my trivial test case (Gaussian patch of tracer in constant flow), negative values do appear, but they do not seem to grow nearly as quickly as before. I'll keep you posted as I scale up to actual fluid dynamics |
…om:CliMA/Oceananigans.jl into ss/disambiguate-boundary-preserving-scheme
|
actual fluid dynamics 🔥 |
|
Hummm I wonder if we can also use a nudging term for negative values in the tracer equation. Also I am not sure where this ends up being a problem but one can try to clip negative values where they are used. For example, CATKE does this for the TKE. |
simone-silvestri
deleted the
ss/disambiguate-boundary-preserving-scheme
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was broken so this PR fixes it. This method is untested and unvalidated so adding tests is probably not required right now.