New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit tolerances in `assert_allclose` in SCC and points tests #88

Open

kemccusker opened this issue Jul 6, 2023 · 0 comments

Labels

TODO

Member

kemccusker commented Jul 6, 2023

e.g. see in tests/test_equity.py

assert_allclose(
        expected.transpose(*sorted(expected.dims)).sortby(list(expected.dims)),
        actual.transpose(*sorted(actual.dims)).sortby(list(actual.dims)),
        rtol=1e-4,
        atol=1e-4,
    )

Tolerances are larger than for other tests. Confirm this is what we need.

The text was updated successfully, but these errors were encountered:

kemccusker mentioned this issue

Reenabling equity tests #84

Merged

kemccusker added the TODO label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment