Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write up an __all__ for all * imports in openest/generate/stdlib.py #65

Open
7 tasks
brews opened this issue Oct 6, 2020 · 0 comments
Open
7 tasks

Comments

@brews
Copy link
Member

brews commented Oct 6, 2020

We're grabbing bloated namespaces from the import *s in openest/generate/stdlib.py.

Would be helpful for a clean API if we could clean up the polluted namespace in stdlib.py. Memory profiling by module namespaces is a messy beast right now because there is so much imported at different levels.

I recommend writing up a global __all__ at the top of the modules, outlining exactly what is exported. This is needed in:

  • openest/generate/base.py
  • openest/generate/daily.py
  • openest/generate/irregular.py
  • openest/generate/yearly.py
  • openest/generate/funcitons.py
  • openest/generate/shortterm.py
  • Also mask the numpy import in stdlib.py by importing it as _np
@brews brews self-assigned this Oct 6, 2020
@brews brews removed their assignment Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant