Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnet: add send completion events #386

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

jalalmostafa
Copy link
Contributor

CNET now has an event to know if sending has been processed.
Now, eth_tx is also linked to chnl_callback. I added 2 new callback types: CHNL_UDP_SENT_TYPE and CHNL_TCP_SENT_TYPE.

Copy link
Contributor

@KeithWiles KeithWiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks really good, thanks for the work!

I had a couple minor comments and some fixes to be done.

examples/cnet-graph/cnet-graph.c Outdated Show resolved Hide resolved
lib/cnet/chnl/chnl_callback.c Outdated Show resolved Hide resolved
lib/cnet/chnl/chnl_callback.c Outdated Show resolved Hide resolved
lib/cnet/chnl/chnl_callback_priv.h Show resolved Hide resolved
lib/cnet/chnl/chnl_callback_priv.h Outdated Show resolved Hide resolved
lib/cnet/eth/eth_tx.c Outdated Show resolved Hide resolved
@jalalmostafa
Copy link
Contributor Author

Thanks for the review, Keith!
I pushed the fixes.

@jalalmostafa jalalmostafa requested a review from KeithWiles July 30, 2024 09:35
@KeithWiles KeithWiles merged commit 956a808 into CloudNativeDataPlane:main Jul 30, 2024
7 checks passed
@jalalmostafa jalalmostafa deleted the sent-complete branch August 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants