Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job view dies if mem_bw metric not available #70

Closed
fodinabor opened this issue Nov 24, 2022 · 2 comments
Closed

Job view dies if mem_bw metric not available #70

fodinabor opened this issue Nov 24, 2022 · 2 comments
Assignees
Labels
backend backend API related issues bug Something isn't working frontend Svelte UI related issues

Comments

@fodinabor
Copy link
Contributor

Related to #69 - for some reason mem_bw is not provided by the /{job-id}?metric=flops_any&metric=mem_bw&... request made when loading both, the job list as well as the job view.

When this happens, the whole page is stuck and does not allow clicking anything anymore.
The dev console prints the following error:

job.js:1 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'metric')
    at Array.J$ (job.js:1:334161)
    at u (job.js:1:536)
    at ko (job.js:1:55798)
    at We (job.js:1:10469)
    at new Oo (job.js:1:57102)
    at Array.Y$ (job.js:1:332872)
    at Object.p (job.js:1:335026)
    at p (job.js:1:894)
    at Object.p (job.js:1:132543)
    at ke (job.js:1:6235)

I guess [the roofline plot](https://github.com/ClusterCockpit/cc-backend/blob/e00e3208caefbba05cd19151a524b09cc0d41bce/web/frontend/src/Job.root.svelte#L118] just assumes that there's always a mem_bw metric (hardcoded :-() and thus has an invalid access there when it's not there.

@moebiusband73 moebiusband73 added bug Something isn't working frontend Svelte UI related issues backend backend API related issues labels Nov 25, 2022
@moebiusband73
Copy link
Member

We also had issues with hanging views. And I also suspected that the access to the roofline metrics is hardcoded is the reason.
We will have a look at it.

@spacehamster87
Copy link
Contributor

Moved .metric selection from Job-Root to Roofline-Component: Roofline now renders even if mem_bw and/or flops_any are missing.

Browser-Console logs more comprehensible errors. Analysis-View and Status-View unaffected by changes.

@spacehamster87 spacehamster87 self-assigned this Jan 18, 2023
spacehamster87 added a commit that referenced this issue May 11, 2023
- Was fixed before, see issue #70
- Probably re-introduced when manually merging large branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend API related issues bug Something isn't working frontend Svelte UI related issues
Projects
None yet
Development

No branches or pull requests

3 participants