Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing OTHER_LDFLAGS #10183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

langyanduan
Copy link

@langyanduan langyanduan commented Oct 31, 2020

PodA.podspec

...
  s.vendored_libraries = "lib/macOS/a.dylib"
...

PodB.podspec

...
  s.source_files = "src/**/*.{h,m}"
  s.dependency 'PodA'
...

App's Podfile:

target 'App' do
  use_frameworks!
  pod 'PodA'
  pod 'PodB'
end

After pod install, OTHER_LDFLAGS in .xcconfig will become

  • APP: OTHER_LDFLAGS = $(inherited) -l"a" -framework "PodB"
  • PodA: OTHER_LDFLAGS = $(inherited) -l"a"
  • PodB: OTHER_LDFLAGS = $(inherited), missing item -l"a"

This will result in a failure to compile the PodB (link failure)


I found that a previous commit was to solve the problem of linking dynamic libraries to static libraries, but no special treatment is needed for linking dynamic libraries to dynamic libraries

#8314
#8204


integration specs CocoaPods/cocoapods-integration-specs#305

@dnkoutso
Copy link
Contributor

@langyanduan hi there, can you rebase this PR? trying to bring certain things up to speed in the project. thanks!

@langyanduan
Copy link
Author

@langyanduan hi there, can you rebase this PR? trying to bring certain things up to speed in the project. thanks!

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants