Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prettier to configs #288

Open
2 tasks
mariekers opened this issue May 4, 2020 · 3 comments
Open
2 tasks

add prettier to configs #288

mariekers opened this issue May 4, 2020 · 3 comments
Labels
frontend javascript Pull requests that update Javascript code

Comments

@mariekers
Copy link
Collaborator

  • husky should run prettier --fix or equivalent before commit attempt, so easy fixes can be handled automatically instead of manually
  • update style rules to require single quote in js syntax and doublequote in jsx
@mariekers mariekers added frontend javascript Pull requests that update Javascript code labels May 4, 2020
@mariekers mariekers added this to the Material UI components milestone May 4, 2020
@ThrowsException
Copy link
Collaborator

This might want to be paired with just a mass reformatting of the code base. Have one giant commit that formats all the files first does two things.

  1. it makes it so that the commit that did the reformatting can be excluded from diffs/blame or at least its a known point in time when the work was done
  2. It makes future work easier because small changes aren't lumped in with large formatting changes making PR's a bit of a pain trying to decide whats an actual change vs what was a formatting change.

@MikeyManoguerra
Copy link
Collaborator

MikeyManoguerra commented May 12, 2020

black formatter works for me for the back end. I doubt anyone will object.

the biggest thing that sticks out to me for the front end code is the quotation marks, lets try and identify any other ones.

PS husky should also run eslint fix. my bad.

@mariekers
Copy link
Collaborator Author

@MikeyManoguerra @ThrowsException would you want a different milestone for reformatting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

3 participants