Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Separate timeout for lavalink downloading #6460

Open
Chovin opened this issue Oct 2, 2024 · 1 comment · May be fixed by #6461
Open

[Audio] Separate timeout for lavalink downloading #6460

Chovin opened this issue Oct 2, 2024 · 1 comment · May be fixed by #6461
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.

Comments

@Chovin
Copy link

Chovin commented Oct 2, 2024

What component of Red (cog, command, API) would you like to see improvements on?

Audio

Describe the enhancement you're suggesting.

Currently there is a single timeout for the combined Lavalink downloading and starting up.

await self.managed_node_controller.start(java_exec)
# timeout is the same as ServerManager.timeout -
# 60s in case of ServerManager(self.config, timeout=60)
await self.managed_node_controller.wait_until_ready()

async def wait_until_ready(self, timeout: Optional[float] = None):
await asyncio.wait_for(self.ready.wait(), timeout=timeout or self.timeout)

It'd be nice if there was a separate timeout specifically for downloading so that those with slow connections can still use managed Lavalink

Anything else?

No response

@Chovin Chovin added the Type: Enhancement Something meant to enhance existing Red features. label Oct 2, 2024
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Oct 2, 2024
@Chovin Chovin linked a pull request Oct 2, 2024 that will close this issue
@Flame442
Copy link
Member

As a workaround, Lavalink is able to be downloaded manually and placed into the correct folder to bypass the timeout of Red downloading it. This still allows the node to be managed (except for auto updating).

There are enough people who come with questions about the timeout that it is something that should probably be addressed, but I don't believe splitting the timeout as described would change anything unless the timeout time is also changed. If splitting would cause it to succeed, then all that would be needed to make the cog work is a [p]reload, as it would have already downloaded Lavalink on the first launch, but would have timed out during the startup process. The next launch would not need to download, so it would finish the startup process in time.

@Flame442 Flame442 added Status: Needs Discussion Needs more discussion. Category: Cogs - Audio This is related to the Audio cog. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: Needs Discussion Needs more discussion. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants