-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out non-Python assets in Publish Release workflow #6440
Merged
Jackenmen
merged 1 commit into
Cog-Creators:V3/develop
from
Jackenmen:split_out_non_python_assets
Aug 28, 2024
Merged
Split out non-Python assets in Publish Release workflow #6440
Jackenmen
merged 1 commit into
Cog-Creators:V3/develop
from
Jackenmen:split_out_non_python_assets
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
added
the
Release Blocker
This needs handling prior to the next non-hotfix release.
label
Aug 27, 2024
github-actions
bot
added
the
Category: CI
This is related to repository's CI configuration.
label
Aug 27, 2024
Kowlin
approved these changes
Aug 28, 2024
red-githubbot
bot
added
the
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
label
Aug 28, 2024
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 28, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434) Co-authored-by: Artemis6969 <[email protected]> * Generate default LL server config and attach it to GH release (Cog-Creators#6430) * [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435) Co-authored-by: Jakub Kuczys <[email protected]> * [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429) * Bump dependencies (Cog-Creators#6436) * Red 3.5.13 - Changelog (Cog-Creators#6437) * Automated Crowdin downstream (Cog-Creators#6439) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.13 (Cog-Creators#6438) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix publish release workflow * Add missing perm to Publish Release workflow * Change Red 3.5.13 release date * Version bump to 3.5.14.dev1 * [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441) * Split out non-Python assets in Publish Release workflow (Cog-Creators#6440) --------- Co-authored-by: Guyonsteroids <[email protected]> Co-authored-by: Artemis6969 <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: aikaterna <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mellow <[email protected]>
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Aug 30, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434) Co-authored-by: Artemis6969 <[email protected]> * Generate default LL server config and attach it to GH release (Cog-Creators#6430) * [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435) Co-authored-by: Jakub Kuczys <[email protected]> * [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429) * Bump dependencies (Cog-Creators#6436) * Red 3.5.13 - Changelog (Cog-Creators#6437) * Automated Crowdin downstream (Cog-Creators#6439) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.13 (Cog-Creators#6438) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix publish release workflow * Add missing perm to Publish Release workflow * Change Red 3.5.13 release date * Version bump to 3.5.14.dev1 * [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441) * Split out non-Python assets in Publish Release workflow (Cog-Creators#6440) --------- Co-authored-by: Guyonsteroids <[email protected]> Co-authored-by: Artemis6969 <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: aikaterna <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mellow <[email protected]>
BenCos17
added a commit
to JARVIS-discordbot/Red-DiscordBot-jarvis
that referenced
this pull request
Sep 1, 2024
* [Trivia] Correct Stephen to Steven (Cog-Creators#6434) Co-authored-by: Artemis6969 <[email protected]> * Generate default LL server config and attach it to GH release (Cog-Creators#6430) * [Audio] Update Lavalink.jar and yt source build numbers (Cog-Creators#6435) Co-authored-by: Jakub Kuczys <[email protected]> * [Audio] Fix trying to send notify message with no channel object (Cog-Creators#6429) * Bump dependencies (Cog-Creators#6436) * Red 3.5.13 - Changelog (Cog-Creators#6437) * Automated Crowdin downstream (Cog-Creators#6439) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Version bump to 3.5.13 (Cog-Creators#6438) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix publish release workflow * Add missing perm to Publish Release workflow * Change Red 3.5.13 release date * Version bump to 3.5.14.dev1 * [Trivia] Correct typos in World Cup trivia list for Golden Glove questions (Cog-Creators#6441) * Split out non-Python assets in Publish Release workflow (Cog-Creators#6440) * Add `header`, `hyperlink` and `subtext` utilities (Cog-Creators#6102) (#19) Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]> --------- Co-authored-by: Guyonsteroids <[email protected]> Co-authored-by: Artemis6969 <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]> Co-authored-by: aikaterna <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mellow <[email protected]> Co-authored-by: Kreusada <[email protected]> Co-authored-by: Kowlin <[email protected]>
Dav-Git
pushed a commit
to Dav-Git/Red-DiscordBot
that referenced
this pull request
Sep 8, 2024
Jackenmen
added
Changelog Entry: Skipped
Changelog entry for this PR is unnecessary.
and removed
Changelog Entry: Pending
Changelog entry for this PR hasn't been added by repo maintainers yet.
labels
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: CI
This is related to repository's CI configuration.
Changelog Entry: Skipped
Changelog entry for this PR is unnecessary.
Release Blocker
This needs handling prior to the next non-hotfix release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The last release wasn't fully released through automation as usual since the recent changes to the workflow had a few issues.
Two of them have been solved while releasing:
But one remained - the
dist/
directory containing files that aren't Python package distribution files caused the upload to PyPI to fail while collecting files to upload. This PR aims to fix that by splitting outapplication.yml
(the only non-distribution artifact) into a different directory.Have the changes in this PR been tested?
No