core(route): Migrate to go_router. #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizlif
requested review from
a team,
Xazin and
developer-rachit
and removed request for
a team
Xazin
reviewed
Sep 27, 2022
Xazin
reviewed
Sep 27, 2022
wizlif
force-pushed
the
core/285/replace-auto_route-with-go_router
branch
2 times, most recently
from
92afbf2 to
9fc9443
Compare
Codecov Report
@@ Coverage Diff @@
## development #290 +/- ##
==============================================
- Coverage 10.17% 9.81% -0.37%
==============================================
Files 136 138 +2
Lines 3657 3781 +124
==============================================
- Hits 372 371 -1
- Misses 3285 3410 +125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Xazin
previously approved these changes
Oct 7, 2022
wizlif
force-pushed
the
core/285/replace-auto_route-with-go_router
branch
from
ff5a074 to
6b5ee08
Compare
|
There is still a trending issue on go_router shell route about maintaining page state. I will not merge till there is a fix for it. The P.R is still in review and hopefully won't take long. |
Alright sounds good, let's try to rebase this branch once in a while or similar, to make the merge easier later. |
wizlif
force-pushed
the
core/285/replace-auto_route-with-go_router
branch
from
eb71e70 to
2015014
Compare
Xazin
force-pushed
the
development
branch
2 times, most recently
from
17043b7 to
10a52fb
Compare
Xazin
force-pushed
the
development
branch
11 times, most recently
from
5be7e86 to
77ff369
Compare
Xazin
force-pushed
the
development
branch
10 times, most recently
from
05db9fc to
1ac5990
Compare
Xazin
force-pushed
the
development
branch
2 times, most recently
from
8906c8d to
649893f
Compare
|
@wizlif Version 7.1.0 of Go Router resolves the issues we have been waiting for 🎉 |
|
Let me do a fresh version of this, feels like a rebase will be crazy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete migration from auto_route to go_router.
Much shorter build runs (Only freezed 😄 )
Will still need some extensive testing
Closes #285