Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Migrate UI Components from collaction_app #5

Open
2 of 14 tasks
Xazin opened this issue Apr 6, 2023 · 0 comments
Open
2 of 14 tasks

[FEATURE] Migrate UI Components from collaction_app #5

Xazin opened this issue Apr 6, 2023 · 0 comments
Labels
core For UIs across all platforms enhancement New feature or request good first issue Good for newcomers mobile Usable for only mobile related UIs

Comments

@Xazin
Copy link
Member

Xazin commented Apr 6, 2023 •
edited by wizlif
Loading

Description:
We want to migrate some of the most common UI Components from collaction_app.

Each successful migration of a Widget should include:

  • Widgetbook use-case inside collaction_book package
  • Unit tests

Additionally some rules/notes for when migrating widgets:

  1. Do NOT use/include state management, eg. Riverpod or BLoC. All Widgets should be decoupled, if they previously relied on a domain model (eg. CrowdAction or Commitment) then create a ViewModel for the Widget, or simply use only required fields.
  2. At least 85% Test Coverage on ALL files added!
  3. Use Theme for colors!
  4. Abstract all onTap or similar functions into fields and callbacks!

Widgets to be Migrated:

  • AccentChip + SecondaryChip (Consider if they can be consolidated)
  • ContentPlaceholder
  • CountryIcon
  • CustomFAB (Consider renaming to eg. CAFab)
  • MicroLock
  • CollAction Icons
  • PhotoSelector
  • PillButton
  • CommitmentCard
  • CustomAppBar
  • PinTextField
  • PinInput

There may be more widgets, feel free to comment below if you think something is a candiate!
@Xazin Xazin added enhancement New feature or request good first issue Good for newcomers core For UIs across all platforms mobile Usable for only mobile related UIs labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core For UIs across all platforms enhancement New feature or request good first issue Good for newcomers mobile Usable for only mobile related UIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xazin