Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: reduce coolwsd memory footprint #10566

Open
mmeeks opened this issue Nov 21, 2024 · 1 comment
Open

perf: reduce coolwsd memory footprint #10566

mmeeks opened this issue Nov 21, 2024 · 1 comment
Labels
24.04 enhancement New feature or request performance Improving COOL performance

Comments

@mmeeks
Copy link
Contributor

mmeeks commented Nov 21, 2024

coolwsd currently stores all of the files we serve in-memory to avoid needing to touch the file-system after start.

Arguably this is good for security, however in some circumstances eg. the appimage use case that's not going to improve things much, at quite some cost in memory.

We should not store un-compressed files in-memory, but only the zipped ones; we should de-compress from these (which is super-fast) if/as/when needed to serve them (in one-shot - that should be a very unusual code-path). That should save around ~40Mb of memory for coolwsd: not earth shattering, but worthwhile - and ~8% of coolwsd's memory usage.

@mmeeks mmeeks added enhancement New feature or request performance Improving COOL performance 24.04 labels Nov 21, 2024
@mmeeks
Copy link
Contributor Author

mmeeks commented Nov 22, 2024

@Ashod might be interesting for you =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 enhancement New feature or request performance Improving COOL performance
Projects
Status: No status
Development

No branches or pull requests

1 participant