Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Custom Keybindings are gone in version 1.4.4 #1612

Closed
LukeG89 opened this issue Nov 20, 2024 · 5 comments
Closed

[Bug]: Custom Keybindings are gone in version 1.4.4 #1612

LukeG89 opened this issue Nov 20, 2024 · 5 comments
Labels
Potential Bug Untriaged bug

Comments

@LukeG89
Copy link

LukeG89 commented Nov 20, 2024

Frontend Version

1.4.4

Expected Behavior

All my custom keybindings are present.

image

Actual Behavior

All my custom keybindings are gone.

image

Steps to Reproduce

  • Run ComfyUI with 1.4.4 frontend version
  • Check Keybindings

Debug Logs

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --disable-all-custom-nodes --preview-size 1024 --front-end-version Comfy-Org/ComfyUI_frontend@latest
Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.6.0.dev20241115+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
Initializing frontend: Comfy-Org/ComfyUI_frontend@latest, requesting version details from GitHub...
[Prompt Server] web root: E:\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.4.4
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188

Browser Logs

image

Setting JSON

comfy.settings.json

What browsers do you use to access the UI ?

Google Chrome

Other

Issue already mentioned here: #1601 (comment)

@huchenlei
Copy link
Member

Culprit reverted

@huchenlei
Copy link
Member

We shall find a better way to migrate keybindings.

@TheToxin-git
Copy link

@LukeG89 Are they gone in 1.7.3 for you?

@LukeG89
Copy link
Author

LukeG89 commented Jan 6, 2025

@LukeG89 Are they gone in 1.7.3 for you?

@TheToxin-git Yep, they're gone...

image

@huchenlei What happened?

@LukeG89
Copy link
Author

LukeG89 commented Jan 6, 2025

Ok, I just saw they are about to fix it:

Edit: Nevermind, the bug still persists in v1.7.4. Just opened a bug report here: #2183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Untriaged bug
Projects
None yet
Development

No branches or pull requests

3 participants