Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Extend custom keybindings to cover basic UI actions provided by litegraph #2015

Open
1 task done
j-jasz opened this issue Dec 22, 2024 · 3 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@j-jasz
Copy link

j-jasz commented Dec 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I want to propose extending keybinding editing option so we can cover basic UI bindings provided by litegraph. I understand that this might be a more long-term project.

My main reasoning is that there are a lot of artists that rely on a day-to-day basis on software with node based UI like Nuke, Houdini, Blender, ect. Those DCCs are on the market for a very long time (sometimes decades) and each has its own distinctive node-related keybindings. Having new application with completely different keys for something that you have already mastered is a frustrating experience.

It would be nice to be able to set ComfyUI shortcuts so they match with those in those programs, so users don't need to fight with their muscle memory. Node based workflows are very distinct and having two different keymaps to learn can hinder productivity in a big way.

This task can be done either gradually or at once depending on its difficulty. Some functions rely on keyboard + mouse combos and ideally those should be editable too - like switching LMB to RMB/MMB.

Proposed workflow

  1. Go to Settings.
  2. Go to Keybinding.
  3. Change selected keybinding ...

Additional information

No response

┆Issue is synchronized with this Notion page by Unito

@webfiltered
Copy link
Contributor

Thank you for linking this through to the other issue - it does help to know which issues are getting a lot of attention.

Just wanted to let you know that this is on the radar. Current plan isn't quite Blender-level customisation, but should cover most needs.

To set expectations, there is no timeline for this (and it won't be done tomorrow). It's important to me, but might be more or less important to ComfyUI & the community.

With the above in mind... a significant portion of the work will be in the UI. Testing the actual customisation will likely happen prior to the UI being available. Two things on this:

  1. If you're interested in testing before the UI goes in, please let me know. Will likely involve a lot of copy/paste into browser console.
  2. Ideally / eventually I'd like to offer presets. I doubt I could do it faithfully myself, so getting industry-standard configurations exported by the community would be amazing.

@j-jasz
Copy link
Author

j-jasz commented Dec 22, 2024

Thanks for the info. I can do some testing. No problem as long as I'm supposed to test only the UI and not networking.
Just let me know in advance. I'll need to schedule free time for this. Preferably during weekend.

I can volunteer to do Blender-compatible preset. In fact, I was thinking about it for some time now, but making new litegraph version just for it didn't looked like a good idea.

@webfiltered
Copy link
Contributor

No worries! The testing will be pretty informal, and at your own leisure - mostly just keeping an eye out for any issues or missed bindings at that stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants