Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of https://github.com/CommitteeOfZero/sc3ntist/pull/1 #2

Closed
casept opened this issue Sep 7, 2022 · 1 comment
Closed

State of https://github.com/CommitteeOfZero/sc3ntist/pull/1 #2

casept opened this issue Sep 7, 2022 · 1 comment

Comments

@casept
Copy link

casept commented Sep 7, 2022

I can't get sc3ntist to build using qmake on Linux. With GCC, it tries to compile src/parser/CCCharset.o and eventually runs out of memory. With clang, it fails to link. Tested on both Ubuntu 22.04 and Arch. However, building using the CMakeLists.txt provided in that PR after adding sc3ntist as a target works just fine, despite the PR not making any changes to the offending source file.

It also adds a character set for Steins;Gate, which is quite helpful as that's the game I want to debug (See CommitteeOfZero/impacto#12).

The C++ version bump to C++17 is also nice.

For these reasons, I'd prefer to base my debugger branch on that work. Is there any chance of the PR being accepted? If not, what would have to be fixed up to get it accepted?

casept added a commit to casept/sc3ntist that referenced this issue Sep 7, 2022
@Enorovan
Copy link
Member

A bit late but it got merged, with txt extraction on top of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants