Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

NoTargets Projects create output folders in PrepareForBuild #286

Open
SamAtMicrosoft opened this issue Nov 9, 2018 · 1 comment
Open

Comments

@SamAtMicrosoft
Copy link
Contributor

The projects which link NoTargets.targets create output folders. This makes empty output folders in the build output.

My theory is that we don't need PrepareForBuild; in the CoreBuildDependsOn in NoTarget.targets. This would also skip the following targets:

GetFrameworkPaths;GetReferenceAssemblyPaths;AssignLinkMetadata

@jeffkl
Copy link
Contributor

jeffkl commented Nov 13, 2018

I think we should have an empty target but leave the extensibility. People might be trying to extend it.

<Target
      Name="PrepareForBuild"
      DependsOnTargets="$(PrepareForBuildDependsOn)" />

<Target
    Name="GetFrameworkPaths" />

  <Target
      Name="GetReferenceAssemblyPaths"
      DependsOnTargets="$(GetReferenceAssemblyPathsDependsOn)" />

We can have empty targets so that GetFrameworkPaths and GetReferenceAssemblyPaths don't do anything but I think AssignLinkMetadata needs to run.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants