Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch darkmode toggle icons display on click #110

Open
Evavic44 opened this issue Jan 25, 2022 · 3 comments
Open

Switch darkmode toggle icons display on click #110

Evavic44 opened this issue Jan 25, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Evavic44
Copy link
Member

Evavic44 commented Jan 25, 2022

The toggle icons show on both light and dark mode, set only one icon to display until clicked.

This will address the issue as stated in #107

@Evavic44 Evavic44 added the bug Something isn't working label Jan 25, 2022
@frankiefab100
Copy link
Member

@Evavic44 It's okay from my end.

Screenshot_20220125-214636

@Evavic44
Copy link
Member Author

This issue is only visible to those that use a dark mode extension on their browser. Case example #107

This forces the page background to be dark and the text and icons light. And since the toggle icons are hidden based on their color, we'll need to opt for a more sophisticated way of hiding them, probably with JavaScript.

But thanks for reviewing, @frankiefab100 . We can implement this gradually as it is not a high-priority issue.

@frankiefab100
Copy link
Member

Alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants