Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard.IsNotWhiteSpace gives exception on null value #441

Open
1 of 4 tasks
vman26 opened this issue Sep 14, 2022 · 0 comments · May be fixed by #650
Open
1 of 4 tasks

Guard.IsNotWhiteSpace gives exception on null value #441

vman26 opened this issue Sep 14, 2022 · 0 comments · May be fixed by #650

Comments

@vman26
Copy link

vman26 commented Sep 14, 2022

Describe the bug
Null check done in Guard.IsNotWhiteSpace while Guard.IsNotNullOrWhiteSpace is also available.
Code of Guard.IsNotWhiteSpace has the same implementation as Guard.IsNotNullOrWhiteSpace.
null does not feel equal to whitespace.

Regression
No response

Steps to reproduce
Call Guard.IsNotWhiteSpace(null), this gives a System.ArgumentException.

Screenshots
No response

IDE and version
VS 2017

IDE version
No response

Nuget packages

  • CommunityToolkit.Common
  • CommunityToolkit.Diagnostics
  • CommunityToolkit.HighPerformance
  • CommunityToolkit.Mvvm (aka MVVM Toolkit)

Nuget package version(s)
8.0.0

Additional context
No response

Help us help you
No, just wanted to report this
@GabrieleMessina GabrieleMessina linked a pull request Mar 18, 2023 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Guard IsWhiteSpace and IsNotWhiteSpace Methods GabrieleMessina/community-toolkit-dotnet
1 participant
@vman26