Skip to content

Commit

Permalink
chore(deps): upgrade polkadot to 0.9.43 (#4106)
Browse files Browse the repository at this point in the history
Removed code to be removed (assets transaction router, lending, dutch
auciton, liquidations, vault, bonded finance, currency-factory) instead
of fixing.

Migrate to XCM ICA from ORML.

Replaced removed crypto with what I have found
https://substrate.stackexchange.com/questions/9754/sp-iocrypto-was-removed-amid-polkadot-0-9-39-and-0-9-43-what-is-replacement

Fixed assets after migration (changed how ops work again ED -
#4107). Only one test
fails - seems something fucked up in Parity burn/slash. Need research
and may be report bug.

Oracle, farming, pablo, rewards migrated with disabled tests and
benchmarks. Same for TX (need to update to latest Parity version instead
of stale CP paste).

Migrated CW.

Seems @kkast migrated oracle, pablo, rewards, farming.

Fixed runtime and node (enabled warp), fixed wasm and benches builds,
updated zombienet respecting updated parameters. Disable IBC benches
until fixes (using old benches - which should be almost same as if to
rerun).

@kkast would be awesome if you can fix look at
cumulus/substrate/polkadot/orml release notes and apply migration we
need from 39 to 43 version. Ensure assets are correct, 1 asset test
asserts..

Required for merge:
- [ ] `pr-workflow-check / draft-release-check` is ✅ success
ComposableFi/composable-ibc#397 (comment)
- Other rules GitHub shows you, or can be read in
[configuration](../terraform/github.com/branches.tf)

Makes review faster:
- [x] PR title is my best effort to provide summary of changes and has
clear text to be part of release notes
- [x] I marked PR by `misc` label if it should not be in release notes
- [x] Linked Zenhub/Github/Slack/etc reference if one exists
#4093
ComposableFi/composable-ibc#397
- [x] I was clear on what type of deployment required to release my
changes (node, runtime, contract, indexer, on chain operation, frontend,
infrastructure) if any in PR title or description
- [x] Added reviewer into `Reviewers`
- [x] I tagged(`@`) or used other form of notification of one person who
I think can handle best review of this PR
- [ ] I have proved that PR has no general regressions of relevant
features and processes required to release into production
- [ ] Any dependency updates made, was done according guides from
relevant dependency
- Clicking all checkboxes 
- Adding detailed description of changes when it feels appropriate (for
example when PR is big)
  • Loading branch information
dzmitry-lahoda authored Sep 8, 2023
1 parent 03e924f commit 8dcf27a
Show file tree
Hide file tree
Showing 338 changed files with 5,412 additions and 38,733 deletions.
4 changes: 2 additions & 2 deletions .github/templates/watch-exec/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ runs:
STATUS_TRANSIENT_FAILURE=200
# Maximum retries in case of network failures.
RETRIES=5
INPUTS_COMMAND="${{ inputs.command }}"
INPUTS_COMMAND="${{ inputs.command }}"
CACHIX="cachix watch-exec --compression-level ${CACHIX_COMPRESSION_LEVEL:-16} --compression-method ${CACHIX_COMPRESSION_METHOD:-"zstd"} --jobs ${CACHIX_JOBS:-16} composable"
NIX_DEBUG_COMMAND="" && [[ $ACTIONS_RUNNER_DEBUG = "true" ]] && NIX_DEBUG_COMMAND='--print-build-logs --debug --show-trace --verbose'
NIX_DEBUG_COMMAND="" && [[ $ACTIONS_RUNNER_DEBUG = "true" ]] && NIX_DEBUG_COMMAND='--print-build-logs --debug --show-trace --verbose --keep-going'
HAPPY_CMD="${CACHIX?} ${INPUTS_COMMAND?} --no-update-lock-file --accept-flake-config ${NIX_DEBUG_COMMAND} -L 2> >(tee --append $LOG_FILE >&2)"
SLOW_CMD="${CACHIX?} ${INPUTS_COMMAND?} --no-update-lock-file --accept-flake-config --show-trace --fallback -L 2 ${NIX_DEBUG_COMMAND} > >(tee --append $LOG_FILE >&2)"
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/pr-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ jobs:
continue-on-error: false
needs:
- privilege-check
- lfs-check
runs-on:
- x86_64-linux-32C-128GB-2TB
concurrency:
Expand Down Expand Up @@ -311,7 +310,7 @@ jobs:
if: ${{ inputs.flow != 'push' }}
uses: "./.github/templates/watch-exec"
with:
command: nix -- build .#all-benchmarks
command: nix -- build .#all-rust-qa-packages
- id: ok
run: echo "ok=true" >> "$GITHUB_OUTPUT"

Expand Down Expand Up @@ -356,7 +355,6 @@ jobs:
ok: ${{ steps.ok.outputs.ok }}
needs:
- privilege-check
- lfs-check
runs-on:
- x86_64-linux-32C-128GB-2TB
concurrency:
Expand Down
1 change: 0 additions & 1 deletion DEPENDENCIES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ For 2, if you are unsure of the legal implications, contact our general council

Exact version of dependencies are more welcomed than wildcards(*).

We pin to a `commit`, not a branch for git dependencies.
Forks with PRs to upstream are welcomed, forks without PRs to upstream are not.

Other things are checked by CI jobs or decided per case.
Binary file not shown.
Binary file removed audits/halborn/audit20220919-pallet-democracy.pdf
Binary file not shown.
Binary file not shown.
Loading

0 comments on commit 8dcf27a

Please sign in to comment.