Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message when we launch the app without setting up environment variables #29

Open
ntraut opened this issue Dec 31, 2020 · 3 comments

Comments

@ntraut
Copy link
Member

ntraut commented Dec 31, 2020

Currently when we build the app without setting up the required environmental variables, we still are able to launch the app but we can't login. Error messages are shown in the dev console but not in the user interface, which could make it difficult to understand when we have no access to the console. Maybe it would be good to have a visual error message for this case also.

@r03ert0
Copy link
Member

r03ert0 commented Dec 31, 2020

For the end user, there should only be a generic error message indicating that we're having a problem ("oh snap!"), and suggesting to try again later.
For us, it would be good to have an e-mail indicating that building failed, like with CircleCI. Once we'll have tests, we should also be prevented of errors by e-mail. Would that be easy to set up?

@ntraut
Copy link
Member Author

ntraut commented Jan 6, 2021

Currently the build pass even without env variables set, maybe it would be better if the build failed.
For being notified when the build fails, I think we can set up something like that in app center. We could also use a classic CI on the SPA app.

@ntraut
Copy link
Member Author

ntraut commented Apr 26, 2021

Maybe not totally solved but at least i added an error message when the variables for the parse api are not correctly set in commit bcf1d3e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants