Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean how we deal with Stamps in the HUB #1494

Open
letypequividelespoubelles opened this issue Nov 11, 2024 · 0 comments
Open

clean how we deal with Stamps in the HUB #1494

letypequividelespoubelles opened this issue Nov 11, 2024 · 0 comments
Labels
cleaning Make the code easier to read by cleaning it

Comments

@letypequividelespoubelles
Copy link
Collaborator

Currently we give to CommonValues (ie to a section):

  • the current Stamps
  • but we just need the hubStamp, and the logStamp (for the first section of a tx, or for logSection)

MmuStamp & MxpStamp increased at commit time, but don't use the Stamps of the CommonValues : as the Stamps is a field of the State it's a StackedList, and thus we spin off the Stamps when we enter a tx. But it means, it's a different pointer for the Stamps in the commonValues, and the one we increase (and actually trace), which is stupid.

What we have now is working but is ugly and not understandable, need to clean this mess.

@letypequividelespoubelles letypequividelespoubelles added the cleaning Make the code easier to read by cleaning it label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Make the code easier to read by cleaning it
Projects
None yet
Development

No branches or pull requests

1 participant