Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to js function #148

Open
parteekcoder opened this issue Mar 18, 2023 · 3 comments
Open

Convert to js function #148

parteekcoder opened this issue Mar 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@parteekcoder
Copy link

Hi @pradeeban ,

The functions here are written in string format https://github.com/ControlCore-Project/concore-editor/blob/main/src/config/defaultValidators.js

Is there any specific reason for this

@pradeeban
Copy link
Member

What is the alternative approach you would suggest?

(Please note these are our previous GSoC students' work from 2022 and 2021. The Concore editor as a whole is a product of GSoC 2021 and 2022.)

@parteekcoder
Copy link
Author

I will make this as JS function and use export/import syntax which will be much better

Why to refactor?
Ans: Now if any person wants to call a function inside that function which is written in string that is not possible . Because it can't find that reference of function called inside that

@pradeeban
Copy link
Member

ok, great.

@pradeeban pradeeban added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants