-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple edges with same name and same source, destination pairs #90
Comments
Are Multiple edges with same names are allowed? You won't be able to make an edge with the same name (CU) from XZ to PZ, though, as that is not a hyperedge. DHGWorkflow (the parent of concore editor) is a directed hypergraph editor. https://github.com/NISYSLAB/DHGWorkflow/ It's a feature! In concore, we allow connecting two nodes with multiple edges and multiple destination nodes with the same hyperedge from the same source. But, in your example, you are connecting the same source-destination pair with multiple identical edges. Is that needed? That is more of a research question on the use cases of concore. I keep the question open for a while. |
ok @pradeeban thanks for clarification , In my perspective identical edges between same nodes are not required But Once it is confirmed please tell me |
Yes. In concore, the representation goes: So, these two cases are actual use cases. case 2 (two edges between a pair of nodes): But the case you have shown is, I will confirm and either close this question (if the above case 3 is valid) or convert this into a bug (if the case 3 is invalid and should be prevented). |
hi @pradeeban have you confirmed this Question |
The above scenario as depicted in the screenshot should not exist. |
so can you please assign me, I will make an PR shortly to solve this Thanks @pradeeban for clarification |
@pradeeban can this be the case A and B nodes A to B with edge parteek |
No, that is a simple loop with the same name for the edges. Not supported in concore. If you try it now, it will throw the message, "Edge with same label exists." (That is the correct behavior). |
Please make sure the PR should not mistakenly open up to allow more cases. We support a subset of hyperedges and avoid the rest. edge = (source, [destination]) is allowed. The above cases are implemented correctly. |
OK please give some time , as i was working in issue #92 |
No worries. Take your time. These are good to fix. But not as urgent. |
hey @pradeeban can you please give me some clearity betweeb case 1 and 3 Please tell me if I am right: How these 2 can occur simultaneously ,please correct me if I am wrong |
Case 1 is a typical hyperedge (you can Google it). One edge connecting more than 2 nodes. Case 3 is just creating identical edges twice with the same label. It is meaningless/duplicate and should not be allowed. |
Your screenshot is case 3 and shouldn't be allowed. (Not a critical issue. You can leave it as is, if in doubt, for now.) |
Are Multiple edges with same names are allowed?
The text was updated successfully, but these errors were encountered: