Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkg-config support #212

Closed
pabigot opened this issue Apr 20, 2018 · 1 comment
Closed

add pkg-config support #212

pabigot opened this issue Apr 20, 2018 · 1 comment

Comments

@pabigot
Copy link
Contributor

pabigot commented Apr 20, 2018

First, thanks for creating this system. I need a C++17 RabbitMQ client in a systemd daemon using sd-event and the contortions I was going through to use rabbitmq-c were disheartening. I have high hopes for this alternative.

I also need pkg-config support, but have been unable to extract the relevant commits from pull request #170. I'm creating this issue for tracking, and will immediately be submitting a PR that provides only that feature.

The only "invasive" change is to add CMake variables for the version number, and to increment the patch version to 3.0.2. The rationale for the increment now is that anything built from current master is no longer 3.0.1 so the versioning should be different. This can be mooted in the PR or here.

@pabigot
Copy link
Contributor Author

pabigot commented Apr 20, 2018

Wow, fast. Thanks. Apparently I haven't managed to learn to close github issues in commit comments correctly yet.

@pabigot pabigot closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant