Replies: 6 comments 4 replies
-
If we keep "CUCustomDev\LaravelStarterKit", will the package name be just "LaravelStarterKit"? I think we should include CD in there somehow. |
Beta Was this translation helpful? Give feedback.
-
As a proposed example the repository would be github.com/CUCustomDev/LaravelStarterKit; the name package would be cucustomdev/laravel-starter-kit, and the namespace for the package would be \CUCustomDev\LaravelStarterKit containing classes like \CUCustomDev\LaravelStarterKit::WhateverClass We just included CD in our names because we were sharing the top level repository name. If the top name is CUCustomDev, then I think the CD would be redundant. |
Beta Was this translation helpful? Give feedback.
-
I'd like to see consistent use of capitals and dashes. It looks to me like "cu-custom-dev/laravel-starter-kit" would be more consistent than "cucustomdev/laravel-starter-kit" for the package name. I'm still personally a bit uneasy with the inconsistency in the repo name vs package name, thinking kebab-case is the more typical approach in the wild. But I don't have a strong opinion or best practice guidance to inform that. I agree that having CD in the package repository name is redundant once we are in our own CU Custom Dev repo. |
Beta Was this translation helpful? Give feedback.
-
In our Devs meeting on Dec. 2, we discussed naming conventions for namespaces and packages. It was boisterous and opinionated! There was not a clear consensus on a single approach, but here were things that people valued:
When actually putting those values into practice, there were three names that settled out as potentials, but no clear winners (and these would be potential names for a GitHub organization just for Custom Development):
For packages or custom modules, the composer package version of that naming would end up being in the form "repo-name/package-name", like:
In the Devs meeting, the suggestion was to let people in Custom Dev do a ranked-choice voting as a way to choose one of these names. |
Beta Was this translation helpful? Give feedback.
-
Voting results: https://app.rankedvote.co/decisions/27623/Custom-Dev-namespace-naming/28744/results
|
Beta Was this translation helpful? Give feedback.
-
Based on the voting results, I suggest a packagist name of cornell-custom-dev/laravel-starter-kit and PHP code namespace of /CornellCustomDev/LaravelStarterKit. That follows prevailing name formatting that I see in packagist. |
Beta Was this translation helpful? Give feedback.
-
It seems we need to come to a consensus on naming soon, based on some discussion in Slack from Nov. 18:
Rich:
Alison:
Irina:
Eric:
Perhaps we can continue the discussion here and settle on a couple rules for naming?
Beta Was this translation helpful? Give feedback.
All reactions