-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Adds all stargate queries for smart contracts #715
base: main
Are you sure you want to change the base?
Conversation
I'm hyped but also scared We need to double check event returns to be ordered and determinism of each of these |
@dimiandre totally agree - I want to have a contract / e2e test which checks all of this with -race across 8+ vals on a network to ensure its safe before merge |
@mikedotexe Are you able to work on a contract for this? You have more rustc proto experience than I do - or maybe a contract which uses Nois's Anybuf? Guidelines if so: Run this repo with the instructions in ./scripts/test_node.sh at the top in this branch
Then I can build a e2e test with 8 validators so we can ensure the chain does not halt for non-determinism. |
Hey! My honest answer is I will probably need to reduce my time after AwesomWasm and OsmoCon to catch up on energy I've lost during my CosmWasm marathon. Maybe we can chat about this in late August? |
I feel the same way. If it's preferable, perhaps we can consider adding a handful of Stargate queries that might unlock a lot of potential. I know Yieldmos is keen on having Authz and FeeGrant queries going. Those might be worthwhile to get in before a larger, blanket acceptance of all Stargate queries? |
accepted := wasmkeeper.AcceptedStargateQueries{ | ||
// wasm | ||
"/cosmwasm.wasm.v1/Query/ContractInfo": &wasmtypes.QueryContractInfoResponse{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be .v1.Query/ oops
Going to have to postpone for a future upgrade, don't have time atm to write the test to ensure these all work. |
@Reecepbcups return values must be deterministic and in same order if array, same for return events |
@dimiandre is right, this is something we should be hyped and scared about, it needs tests. |
Closes #714
TODO: