CASMCMS-8835: Do not prematurely filter out disabled nodes #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To truly allow the 'include_disabled' nodes capability, the power operators cannot filter out the disabled nodes. This mod removes that filter. The session's 'include_disabled' nodes attribute will be used in the session setup operator to decide whether the nodes will be enabled in BOS or not. If disabled nodes are not included, then they will never be enabled and never acted upon. Thus, including them in the query to HSM will not hurt anything because they will never be acted upon. When filtering nodes by architecture, do not also filter by whether the nodes are enabled in HSM. This is done at a later step in the process. Doing this earlier thwarts the later filtering.
rbak-hpe
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
To truly allow the 'include_disabled' nodes capability, the power operators cannot filter out the disabled nodes. This mod removes that filter. The session's 'include_disabled' nodes attribute will be used in the session setup operator to decide whether the nodes will be enabled in BOS or not. If disabled nodes are not included, then they will never be enabled and never acted upon. Thus, including them in the query to HSM will not hurt anything because they will never be acted upon.
When filtering nodes by architecture, do not also filter by whether the nodes are enabled in HSM. This is done at a later step in the process. Doing this earlier thwarts the later filtering.
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
List the environments in which these changes were tested.
Tested on:
MugTest description:
I disabled some nodes and launched BOS sessions with the include_disabled attribute set to true. I saw that these nodes were passed along to PCS, which happily rebooted them despite them being disabled in HSM.
Risks and Mitigations
Low
Pull Request Checklist