-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAYSAT-1392: Graceful handle of user token expiry #252
CRAYSAT-1392: Graceful handle of user token expiry #252
Conversation
Manually the expire date was changed in the ~/.config/sat/tokens/api_gw_service_nmn_local.vers.json to recreate the issue and then validated. |
ea8e201
to
7adec2a
Compare
Testing output on rocket: (d950e16dc37a) sat-container:/ # sat status |
7adec2a
to
003163b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall approach looks good. Needs minor improvements.
003163b
to
20f6c74
Compare
During the sat status execution if the user token is expired, there is a traceback which comes as the output. Hence graceful handling of the token expiry is added to inform the user.
20f6c74
to
93c43d4
Compare
Summary and Scope
During the sat status execution if the user token is expired, there is a traceback which comes as the output. Hence graceful handling of the token expiry is added to inform the user.
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
List the environments in which these changes were tested.
Tested on:
Test description:
Manually the expiry date was updated in ~/.config/sat/tokens/api_gw_service_nmn_local.vers.json to replicate the issue.
And then the sat commands such as sat status, hwinv, hwmatch were executed to validate the changes
Risks and Mitigations
Low risk
Pull Request Checklist