-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAYSAT-1884: Updating cray-product-catalog & csm-api-client to latest versions #258
CRAYSAT-1884: Updating cray-product-catalog & csm-api-client to latest versions #258
Conversation
…t versions. Reviewer:Ryan
Testing was done on surtur,rocket for lower versions than 2.3.1 and for 2.3.1 it was tested on gamora system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially you are on track. The code changes looks good to me. But, you have to update new version of cray-product-catalog
in cfs-config-util repository, get the new unstable build and test with cfs-config-util
commands.
Testing cfs-config-util
commands with this build doesn't make sense to me.
Ok, the testing for cfs-config-util will be done with new unstable build in respective repo. are this repo specific testing satisfactory? |
Yes, the other testings are pretty good. But once the PR on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the code changes as testing of related sat
commands looks good
Summary and Scope
Updating cray-product-catalog & csm-api-client to latest versions
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
List the environments in which these changes were tested.
Tested on:
Test description:
Test the below SAT utilities
sat showrev --products
sat bootprep
cfs-config-util
Risks and Mitigations
Minimal
Pull Request Checklist