Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1893: Make default BOS timeouts infinite #259

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

annapoorna-s-alt
Copy link
Contributor

@annapoorna-s-alt annapoorna-s-alt commented Aug 26, 2024

Summary and Scope

Changed sat bootsys to enable default timeouts to infinite for BOS boot, shutdown, and reboot.
Updated the man page appropriately

Issues and Related PRs

Resolves CRAYSAT-1893.

Testing

List the environments in which these changes were tested.

Tested on:

  • drax

Test description:

Will test by doing shutdown, boot and reboot of bos-operations stage with and without timeout options

Risks and Mitigations

Minimal

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@annapoorna-s-alt annapoorna-s-alt force-pushed the CRAYSAT-1893-timeout-bos-to-infinite branch 2 times, most recently from e6ed813 to 6601765 Compare August 27, 2024 11:50
@annapoorna-s-alt
Copy link
Contributor Author

Testing output on drax

Copy link
Contributor

@shivaprasad-metimath shivaprasad-metimath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user perspective comment can be addressed.

else the PR looks good

docs/man/sat-bootsys.8.rst Outdated Show resolved Hide resolved
@annapoorna-s-alt annapoorna-s-alt force-pushed the CRAYSAT-1893-timeout-bos-to-infinite branch from 6601765 to c031183 Compare September 2, 2024 05:57
docs/man/sat-bootsys.8.rst Outdated Show resolved Hide resolved
Changed `sat bootsys` to enable default timeouts to infinite for
BOS boot, shutdown, and reboot.
@annapoorna-s-alt annapoorna-s-alt force-pushed the CRAYSAT-1893-timeout-bos-to-infinite branch from c031183 to 4de4175 Compare September 2, 2024 10:54
@annapoorna-s-alt annapoorna-s-alt merged commit 81beb65 into main Sep 2, 2024
3 checks passed
@annapoorna-s-alt annapoorna-s-alt deleted the CRAYSAT-1893-timeout-bos-to-infinite branch September 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants