CRAYSAT-1841: Update sat status to support CFS v2 or v3 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IM:CRAYSAT-1841 Reviewer: Shiva Will add the cfs v2 and v3 changes to `sat status`
annapoorna-s-alt
requested review from
haasken-hpe,
shivaprasad-metimath and
vinanti-p
|
Please find the testing output here: https://gist.github.com/annapoorna-s-alt/062eee97a9b774ed6ca4e7d0fe3e4254 |
vinanti-p
approved these changes
Sep 11, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Update sat to use the new version of
csm-api-clientimplemented in CRAYSAT-1840sat statusto support both cfs v2 and v3Issues and Related PRs
Resolves CRAYSAT-1841.
Testing
List the environments in which these changes were tested.
Tested on:
drax
Test description:
Test the
sat statuswith cfs v2 and v3 and without cfs field to test the default.Possibly will try to change the page size and test cfs v3
Risks and Mitigations
Risks might be depend on cfs v3 introduction
Pull Request Checklist