Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt]: Remove zombie code from Sidebar.tsx file #2962

Open
emilydrakesmith opened this issue Sep 4, 2023 · 1 comment
Open

[Tech Debt]: Remove zombie code from Sidebar.tsx file #2962

emilydrakesmith opened this issue Sep 4, 2023 · 1 comment
Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work

Comments

@emilydrakesmith
Copy link
Contributor

What is needed?

The file Sidebar.tsx has two state values managed by useState() hooks named searchInput and searchMode

These values were created some time ago before search functionality had been extracted to the useSidebarSearch() hook. However, they're still present and being used functionally in the file's control flow. These files should be removed and any valid functionality should be replaced with data returned from and managed by useSidebarSearch.ts
@emilydrakesmith emilydrakesmith added good first issue Good for newcomers technical debt This issue involves deferred engineering work low-prio v1.5 (Sep. 21) labels Sep 4, 2023
@Jadessu Jadessu self-assigned this Sep 14, 2023
@consolexyz
Copy link

can i get this assigned to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low-prio technical debt This issue involves deferred engineering work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benwolski @consolexyz @emilydrakesmith @Jadessu