Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt]: migrate /account tabs to react-icons assets #3542

Open
emilydrakesmith opened this issue Mar 14, 2024 · 0 comments
Open

[Tech Debt]: migrate /account tabs to react-icons assets #3542

emilydrakesmith opened this issue Mar 14, 2024 · 0 comments
Labels
low-prio technical debt This issue involves deferred engineering work

Comments

@emilydrakesmith
Copy link
Contributor

What is needed?

Most of the icons used in the PortfolioTabs.tsx file are hosted locally in the app although they all appear to be assets from the react-icons package. If there's a compelling reason to use this pattern we should add comments to the file explaining such and host the <FaMedal /> image similarly. If not, we should migrate asset sourcing in the file to react-icons and delete the assets from the /src directory.

Neither implementation is inherently better but we should have a consistent source for all icons being used in the file.

image

@emilydrakesmith emilydrakesmith added technical debt This issue involves deferred engineering work low-prio labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-prio technical debt This issue involves deferred engineering work
Projects
None yet
Development

No branches or pull requests

1 participant