You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the icons used in the PortfolioTabs.tsx file are hosted locally in the app although they all appear to be assets from the react-icons package. If there's a compelling reason to use this pattern we should add comments to the file explaining such and host the <FaMedal /> image similarly. If not, we should migrate asset sourcing in the file to react-icons and delete the assets from the /src directory.
Neither implementation is inherently better but we should have a consistent source for all icons being used in the file.
The text was updated successfully, but these errors were encountered:
What is needed?
Most of the icons used in the
PortfolioTabs.tsx
file are hosted locally in the app although they all appear to be assets from thereact-icons
package. If there's a compelling reason to use this pattern we should add comments to the file explaining such and host the<FaMedal />
image similarly. If not, we should migrate asset sourcing in the file toreact-icons
and delete the assets from the/src
directory.Neither implementation is inherently better but we should have a consistent source for all icons being used in the file.
The text was updated successfully, but these errors were encountered: